William McKinley has surely been underrated - in no small part because he was succeeded by a memorable leader, Theodore Roosevelt.